git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From 4210ef801a248223a0ea5f47b5446081b4925e10 Mon Sep 17 00:00:00 2001
   2 From: Andy Shevchenko <andy.shevchenko@gmail.com>
   3 Date: Fri, 29 Mar 2024 12:55:20 +0200
   4 Subject: [PATCH] pinctrl: aw9523: Get rid of redundant ' & U8_MAX' pieces
   5
   6 When the variable is declared as u8, no need to perform ' & U8_MAX'
   7 as it's implied anyway.
   8
   9 Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
  10 Message-ID: <20240329105634.712457-7-andy.shevchenko@gmail.com>
  11 Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  12 ---
  13  drivers/pinctrl/pinctrl-aw9523.c | 14 +++++++-------
  14  1 file changed, 7 insertions(+), 7 deletions(-)
  15
  16 --- a/drivers/pinctrl/pinctrl-aw9523.c
  17 +++ b/drivers/pinctrl/pinctrl-aw9523.c
  18 @@ -603,7 +603,7 @@ static int aw9523_gpio_get_multiple(stru
  19         mutex_lock(&awi->i2c_lock);
  20
  21         /* Port 0 (gpio 0-7) */
  22 -       m = *mask & U8_MAX;
  23 +       m = *mask;
  24         if (m) {
  25                 ret = _aw9523_gpio_get_multiple(awi, 0, &state, m);
  26                 if (ret)
  27 @@ -612,7 +612,7 @@ static int aw9523_gpio_get_multiple(stru
  28         *bits = state;
  29
  30         /* Port 1 (gpio 8-15) */
  31 -       m = (*mask >> 8) & U8_MAX;
  32 +       m = *mask >> 8;
  33         if (m) {
  34                 ret = _aw9523_gpio_get_multiple(awi, AW9523_PINS_PER_PORT,
  35                                                 &state, m);
  36 @@ -635,20 +635,20 @@ static void aw9523_gpio_set_multiple(str
  37         unsigned int reg;
  38         int ret;
  39
  40 -       mask_lo = *mask & U8_MAX;
  41 -       mask_hi = (*mask >> 8) & U8_MAX;
  42 +       mask_lo = *mask;
  43 +       mask_hi = *mask >> 8;
  44 +       bits_lo = *bits;
  45 +       bits_hi = *bits >> 8;
  46 +
  47         mutex_lock(&awi->i2c_lock);
  48         if (mask_hi) {
  49                 reg = AW9523_REG_OUT_STATE(AW9523_PINS_PER_PORT);
  50 -               bits_hi = (*bits >> 8) & U8_MAX;
  51 -
  52                 ret = regmap_write_bits(awi->regmap, reg, mask_hi, bits_hi);
  53                 if (ret)
  54                         dev_warn(awi->dev, "Cannot write port1 out level\n");
  55         }
  56         if (mask_lo) {
  57                 reg = AW9523_REG_OUT_STATE(0);
  58 -               bits_lo = *bits & U8_MAX;
  59                 ret = regmap_write_bits(awi->regmap, reg, mask_lo, bits_lo);
  60                 if (ret)
  61                         dev_warn(awi->dev, "Cannot write port0 out level\n");